WIP: Update snapshot and record #742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not just that right? It should be also about resolving some memory management issues. |
|
Or this is for the next PR? |
|
Yes and No @Garyfallidis. Yes -> it promotes good practice and avoid the memory leak. see below, no memory leak t = np.linspace(-10, 10, 100)
bundle = []
for i in np.linspace(3, 5, 1000):
pts = np.vstack((np.cos(2 * t/np.pi), np.zeros(t.shape) + i*10, t )).T
bundle.append(pts)
# No memory when show manager outside the loop
showm = window.ShowManager()
for time in range(200):
ren.scene.clear()
bundle_actor = actor.streamtube(bundle, window.colors.red, linewidth=0.01)
showm.scene.add(bundle_actor)
showm.scene.SetBackground(*window.colors.white)
image_array = window.snapshot(
showm, fname='images/file%02d.png' % time, size=(1000, 1000))No -> the memory leak is from VTK, C++ based, so it will be always there until they fix it. the example below have a memory leak: t = np.linspace(-10, 10, 100)
bundle = []
for i in np.linspace(3, 5, 1000):
pts = np.vstack((np.cos(2 * t/np.pi), np.zeros(t.shape) + i*10, t )).T
bundle.append(pts)
# ren = window.Scene()
for time in range(200):
# Memory leak here, creation of multiple RenderWindow not well freed by vtk
ren = window.ShowManager()
ren.scene.clear()
bundle_actor = actor.streamtube(bundle, window.colors.red, linewidth=0.01)
ren.scene.add(bundle_actor)
ren.scene.SetBackground(*window.colors.white)
image_array = window.snapshot(
ren, fname='images/file%02d.png' % time, size=(1000, 1000)) |
|
This PR is ready to go @Garyfallidis. 2 PR will follow this PR: Update tests, then update tutorials |
Garyfallidis
approved these changes
Feb 16, 2023
|
|
||
| self.window.SetOffScreenRendering(previous_offscreen) | ||
|
|
||
| def snapshot( |
There was a problem hiding this comment.
In the next PR please bring these parameters up so we can save a few lines. It makes reading the code much easier.
|
Unfortunately, there are some issues with viz_timer.py in Ubuntu. Happy to zoom. Hard to explain with words here. |
skoudoro
force-pushed
the
update-snapshot
branch
from
f3ffc40
to
b61f43e
Compare
Garyfallidis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update
snapshotandrecordfunction to allowShowManageras input argument and deprecateSceneas an input arguments.Many PR will follow-up to clean our tests and tutorial by forcing the use of
ShowManager#196